[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=397014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397014
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/20 20:41
Start Date: 03/Mar/20 20:41
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11005: [BEAM-8335]
Modify the StreamingCache to subclass the CacheManager
URL: https://github.com/apache/beam/pull/11005#discussion_r387271259
##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -432,6 +455,45 @@ def finish_bundle(self):
self, self.bundles, [], None, {None: self._watermark})
+class PairWithTimingEvaluator(_TransformEvaluator):
+ """TransformEvaluator for the PairWithTiming transform.
+
+ This transform takes an element as an input and outputs
+ KV(element, `TimingInfo`). Where the `TimingInfo` contains both the
+ processing time timestamp and watermark.
+ """
+ def __init__(
+ self,
+ evaluation_context,
+ applied_ptransform,
+ input_committed_bundle,
+ side_inputs):
+ assert not side_inputs
+ super(PairWithTimingEvaluator, self).__init__(
+ evaluation_context,
+ applied_ptransform,
+ input_committed_bundle,
+ side_inputs)
+
+ def start_bundle(self):
+ main_output = list(self._outputs)[0]
+ self.bundle = self._evaluation_context.create_bundle(main_output)
+
+ def process_element(self, element):
+ watermark_manager = self._evaluation_context._watermark_manager
+ watermarks = watermark_manager.get_watermarks(self._applied_ptransform)
+
+ output_watermark = watermarks.output_watermark
+ now = Timestamp(seconds=watermark_manager._clock.time())
+ timing_info = TimingInfo(now, output_watermark)
+
+ element.value = (element.value, timing_info)
Review comment:
Don't mutate the input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 397014)
Time Spent: 84h 10m (was: 84h)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 84h 10m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
