[ 
https://issues.apache.org/jira/browse/BEAM-9424?focusedWorklogId=397669&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397669
 ]

ASF GitHub Bot logged work on BEAM-9424:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Mar/20 15:58
            Start Date: 04/Mar/20 15:58
    Worklog Time Spent: 10m 
      Work Description: reuvenlax commented on issue #11034: [BEAM-9424] Allow 
grouping by LogicalType
URL: https://github.com/apache/beam/pull/11034#issuecomment-594625264
 
 
   The whole point of Logical types is that the representation should be that 
of the base type (the schema returned by getBaseType). This means that the 
logical type can be processed by code that doesn't know about InputT, and also 
makes it possible to use it cross language. 
   
   Where in Group do we need Coder<InputT>? I feel like I'm still missing 
something.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 397669)
    Time Spent: 3h 20m  (was: 3h 10m)

> Grouping By LogicalTypes is not supported
> -----------------------------------------
>
>                 Key: BEAM-9424
>                 URL: https://issues.apache.org/jira/browse/BEAM-9424
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.19.0
>            Reporter: fdiazgon
>            Assignee: fdiazgon
>            Priority: Minor
>              Labels: sql
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Creating a schema from a BQ schema that has either TIME, DATE or DATETIME 
> columns, and grouping by one of these fields throws NullPointerException.
> {code:java}
> Pipeline pipeline = Pipeline.create();
> Schema beamSchemaWithLogicalTypes =
>     BigQueryUtils.fromTableSchema(
>         new TableSchema()
>             .setFields(
>                 Arrays.asList(
>                     new TableFieldSchema().setName("fTime").setType("TIME"),
>                     new TableFieldSchema().setName("fDate").setType("DATE"),
>                     new 
> TableFieldSchema().setName("fDatetime").setType("DATETIME"))));
> Row row =
>     Row.withSchema(beamSchemaWithLogicalTypes)
>         .addValues(
>             DateTime.parse("2020-02-02"),
>             DateTime.parse("2020-02-02"),
>             DateTime.parse("2020-02-02T00:00:00"))
>         .build();
> PCollection<Row> outputRow =
>     pipeline
>         .apply(Create.of(row))
>         .setRowSchema(beamSchemaWithLogicalTypes)
>         .apply(
>             SqlTransform.query(
>                 "SELECT fTime, fDate, fDatetime FROM PCOLLECTION GROUP BY 
> fTime, fDate, fDatetime"));
> pipeline.run();
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to