[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=397803&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397803
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/20 19:26
Start Date: 04/Mar/20 19:26
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on pull request #11005:
[BEAM-8335] Modify the StreamingCache to subclass the CacheManager
URL: https://github.com/apache/beam/pull/11005#discussion_r387883702
##########
File path: sdks/python/apache_beam/runners/direct/clock.py
##########
@@ -44,11 +46,11 @@ def time(self):
class TestClock(object):
"""Clock used for Testing"""
- def __init__(self, current_time=0):
- self._current_time = current_time
+ def __init__(self, current_time=None):
+ self._current_time = current_time if current_time else Timestamp()
def time(self):
- return self._current_time
+ return float(self._current_time)
Review comment:
Not changing it, fixing it. The TestClock has the same interface as the
RealClock and should return the same thing. See the comment on the Clock
interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 397803)
Time Spent: 88h 40m (was: 88.5h)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 88h 40m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
