[
https://issues.apache.org/jira/browse/BEAM-9288?focusedWorklogId=397896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397896
]
ASF GitHub Bot logged work on BEAM-9288:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/20 21:15
Start Date: 04/Mar/20 21:15
Worklog Time Spent: 10m
Work Description: amaliujia commented on issue #10940: [BEAM-9288] Not
bundle conscrypt in gRPC vendor
URL: https://github.com/apache/beam/pull/10940#issuecomment-594847927
@sunjincheng121
This PR seems not stop adding conscrypt native libraries as part in META-INF.
```
$ jar tvf beam-vendor-grpc-1_26_0-0.3.jar | grep conscrypt
2218176 Mon Sep 17 10:36:24 CEST 2018
META-INF/native/libconscrypt_openjdk_jni-linux-x86_64.so
1720832 Mon Sep 17 10:36:24 CEST 2018
META-INF/native/conscrypt_openjdk_jni-windows-x86.dll
2637496 Mon Sep 17 10:36:24 CEST 2018
META-INF/native/libconscrypt_openjdk_jni-osx-x86_64.dylib
2557952 Mon Sep 17 10:36:24 CEST 2018
META-INF/native/conscrypt_openjdk_jni-windows-x86_64.dll
```
I am not familiar with this part of build system but I am willing to help.
Is there a known resolution in your mind that you can share to remove
`conscrypt` from META-INF?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 397896)
Time Spent: 4h 50m (was: 4h 40m)
> Conscrypt shaded dependency
> ---------------------------
>
> Key: BEAM-9288
> URL: https://issues.apache.org/jira/browse/BEAM-9288
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Esun Kim
> Assignee: sunjincheng
> Priority: Critical
> Fix For: 2.20.0
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Conscrypt is not designed to be shaded properly mainly because of so files. I
> happened to see BEAM-9030 (*1) creating a new vendored gRPC shading Conscrypt
> (*2) in it. I think this could make a problem when new Conscrypt is brought
> by new gcsio depending on gRPC-alts (*4) in a dependency chain. (*5) In this
> case, it may have a conflict when finding proper so files for Conscrypt.
> *1: https://issues.apache.org/jira/browse/BEAM-9030
> *2:
> [https://github.com/apache/beam/blob/e24d1e51cbabe27cb3cc381fd95b334db639c45d/buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy#L78]
> *3: https://issues.apache.org/jira/browse/BEAM-6136
> *4: [https://mvnrepository.com/artifact/io.grpc/grpc-alts/1.27.0]
> *5: https://issues.apache.org/jira/browse/BEAM-8889
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
