[
https://issues.apache.org/jira/browse/BEAM-9442?focusedWorklogId=398337&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398337
]
ASF GitHub Bot logged work on BEAM-9442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/20 12:17
Start Date: 05/Mar/20 12:17
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #11046: [BEAM-9442]
Properly handle nullable fields in Select
URL: https://github.com/apache/beam/pull/11046#discussion_r388257264
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectByteBuddyHelpers.java
##########
@@ -256,6 +260,10 @@ public StackManipulation append(StackManipulation
valueToWrite) {
return store(currentArrayField++, valueToWrite);
}
+ public int reserveSlot() {
Review comment:
nit: (slightly related to this PR) can we make `SelectByteBuddyHelpers`
package private please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 398337)
Time Spent: 20m (was: 10m)
> Schema Select does not properly handle nested nullable fields
> -------------------------------------------------------------
>
> Key: BEAM-9442
> URL: https://issues.apache.org/jira/browse/BEAM-9442
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-harness
> Reporter: Reuven Lax
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A select of a nested field should be nullable if any of its parents are
> nullable. So for example, a select of "a.b" should return a field named b
> that is nullable if _either_ of a or b is nullable. Today we only examine b
> to see if the selected fields should be nullable.
> Also the Select transform itself does not properly check for null values, and
> throws NullPointerExceptions when some row values are null.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
