[
https://issues.apache.org/jira/browse/BEAM-9446?focusedWorklogId=398401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398401
]
ASF GitHub Bot logged work on BEAM-9446:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/20 14:28
Start Date: 05/Mar/20 14:28
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #11052: [BEAM-9446] Add
missing parallelism and execution mode args.
URL: https://github.com/apache/beam/pull/11052#discussion_r388327586
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -1075,6 +1075,22 @@ def _add_argparse_args(cls, parser):
' directly, rather than starting up a job server.'
' Only applies when flink_master is set to a'
' cluster address. Requires Python 3.6+.')
+ parser.add_argument(
+ '--parallelism',
+ default=-1,
+ type=int,
+ help='The degree of parallelism to be used when distributing '
+ 'operations onto workers. If the parallelism is not set, the '
+ 'configured Flink default is used, or 1 if none can be found.'
+ )
+ parser.add_argument(
+ '--execution_mode_for_batch',
Review comment:
I'm not sure we should add these here because that's what we used to do and
it was inconsistent and hard to maintain. What we want to do, is to not discard
those options but still warn about them not being parsed in the Python SDK.
This will allow us to still use them in the Runner code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 398401)
Time Spent: 40m (was: 0.5h)
> FlinkRunner discards parallelism and execution_mode_for_batch pipeline options
> ------------------------------------------------------------------------------
>
> Key: BEAM-9446
> URL: https://issues.apache.org/jira/browse/BEAM-9446
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Labels: portability-flink
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I need these options for TFX, but they're being discarded (I believe they are
> normally supplied by the job server).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
