[
https://issues.apache.org/jira/browse/BEAM-9056?focusedWorklogId=398618&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398618
]
ASF GitHub Bot logged work on BEAM-9056:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/20 19:21
Start Date: 05/Mar/20 19:21
Worklog Time Spent: 10m
Work Description: ihji commented on pull request #10621: [BEAM-9056]
Staging artifacts from environment
URL: https://github.com/apache/beam/pull/10621#discussion_r388509693
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -261,14 +263,20 @@ public String registerCoder(Coder<?> coder) throws
IOException {
* return the same unique ID.
*/
public String registerEnvironment(Environment env) {
+ String environmentId;
String existing = environmentIds.get(env);
if (existing != null) {
- return existing;
+ environmentId = existing;
+ } else {
+ String name = uniqify(env.getUrn(), environmentIds.values());
+ environmentIds.put(env, name);
+ componentsBuilder.putEnvironments(name, env);
+ environmentId = name;
}
- String name = uniqify(env.getUrn(), environmentIds.values());
- environmentIds.put(env, name);
- componentsBuilder.putEnvironments(name, env);
- return name;
+ if (defaultEnvironmentId == null) {
Review comment:
If we change the signature of `registerEnvironment`, a number of test files
(*TranslationTest, *RunnerTest) also need to be touched. I think it will create
unnecessary noise in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 398618)
Time Spent: 5.5h (was: 5h 20m)
> Staging artifacts from environment
> ----------------------------------
>
> Key: BEAM-9056
> URL: https://issues.apache.org/jira/browse/BEAM-9056
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> staging artifacts from artifact information embedded in environment proto.
> detail:
> https://docs.google.com/document/d/1L7MJcfyy9mg2Ahfw5XPhUeBe-dyvAPMOYOiFA1-kAog
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
