[
https://issues.apache.org/jira/browse/BEAM-9448?focusedWorklogId=398728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398728
]
ASF GitHub Bot logged work on BEAM-9448:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/20 22:18
Start Date: 05/Mar/20 22:18
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #11051: [BEAM-9448] Fix
log message for job server cache.
URL: https://github.com/apache/beam/pull/11051#discussion_r388600537
##########
File path: sdks/python/apache_beam/utils/subprocess_server.py
##########
@@ -194,9 +194,11 @@ def local_jar(cls, url):
if os.path.exists(url):
return url
else:
- _LOGGER.warning('Downloading job server jar from %s' % url)
cached_jar = os.path.join(cls.JAR_CACHE, os.path.basename(url))
- if not os.path.exists(cached_jar):
+ if os.path.exists(cached_jar):
+ _LOGGER.warning('Using cached job server jar from %s' % url)
+ else:
+ _LOGGER.warning('Downloading job server jar from %s' % url)
Review comment:
Changed it to `info`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 398728)
Time Spent: 0.5h (was: 20m)
> Misleading log line: says "downloading" when using cache
> --------------------------------------------------------
>
> Key: BEAM-9448
> URL: https://issues.apache.org/jira/browse/BEAM-9448
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Trivial
> Labels: portability-flink
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> https://github.com/apache/beam/blob/8d253ac99d78ef5345245ed71c7cf34328c55d9f/sdks/python/apache_beam/utils/subprocess_server.py#L197
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
