[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=399487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-399487
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/20 01:09
Start Date: 07/Mar/20 01:09
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11005: [BEAM-8335]
Modify the StreamingCache to subclass the CacheManager
URL: https://github.com/apache/beam/pull/11005#discussion_r389208621
##########
File path: sdks/python/apache_beam/runners/direct/test_stream_impl.py
##########
@@ -226,17 +237,53 @@ def expand(self, pcoll):
def _infer_output_coder(self, input_type=None, input_coder=None):
return self.coder
- def _events_from_script(self, index):
- yield self._events[index]
-
- def events(self, index):
- return self._events_from_script(index)
-
- def begin(self):
- return 0
-
- def end(self, index):
- return index >= len(self._events)
+ @staticmethod
+ def events_from_script(events):
+ """Yields the in-memory events.
+ """
+ return itertools.chain(events)
- def next(self, index):
- return index + 1
+ @staticmethod
+ def events_from_rpc(endpoint, output_tags, coder):
+ """Yields the events received from the given endpoint.
+ """
+ stub_channel = grpc.insecure_channel(endpoint)
+ stub = beam_runner_api_pb2_grpc.TestStreamServiceStub(stub_channel)
+
+ # Request the PCollections that we are looking for from the service.
+ if list(output_tags) == [None]:
Review comment:
What's the convention for this list being empty then? (And if it can be
empty, in what cases do we have to provide it? Or should we explicitly be
turning None to 'None'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 399487)
Time Spent: 101h 10m (was: 101h)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 101h 10m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
