[
https://issues.apache.org/jira/browse/BEAM-9295?focusedWorklogId=400723&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400723
]
ASF GitHub Bot logged work on BEAM-9295:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/20 13:53
Start Date: 10/Mar/20 13:53
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10945: [BEAM-9295] Add
Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10
URL: https://github.com/apache/beam/pull/10945#discussion_r390328606
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
##########
@@ -77,6 +67,7 @@ static ExecutionEnvironment createBatchExecutionEnvironment(
// depending on the master, create the right environment.
if ("[local]".equals(flinkMasterHostPort)) {
+ flinkConfiguration.setString("taskmanager.memory.managed.size", "2048m");
Review comment:
I'm hesitant with this default because it will always pre-allocate 2GB of
memory which won't be used most of the time, except for the one large record
test case you mentioned.
We could set I'd go for something like
https://github.com/apache/flink/blob/42a56f4c75693773e21fa2dea45df640c2d7f9da/flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorProcessUtils.java#L287
based on the memory available.
Actually, that is what the Flink 1.8 code used to do:
https://github.com/apache/flink/blob/60d9b96456f142f8d18d5882016840a00159403e/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java#L296
So let's just check the free memory and use a fraction for memory managed
memory by default. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 400723)
Time Spent: 5h 10m (was: 5h)
> Add Flink 1.10 build target and Make FlinkRunner compatible with Flink 1.10
> ---------------------------------------------------------------------------
>
> Key: BEAM-9295
> URL: https://issues.apache.org/jira/browse/BEAM-9295
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Apache Flink 1.10 has completed the final release vote, see [1]. So, I would
> like to add Flink 1.10 build target and make Flink Runner compatible with
> Flink 1.10.
> And I appreciate it if you can leave your suggestions or comments!
> [1]
> https://lists.apache.org/thread.html/r97672d4d1e47372cebf23e6643a6cc30a06bfbdf3f277b0be3695b15%40%3Cdev.flink.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
