[ https://issues.apache.org/jira/browse/BEAM-9470?focusedWorklogId=401827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-401827 ]
ASF GitHub Bot logged work on BEAM-9470: ---------------------------------------- Author: ASF GitHub Bot Created on: 11/Mar/20 22:15 Start Date: 11/Mar/20 22:15 Worklog Time Spent: 10m Work Description: suztomo commented on pull request #11090: [BEAM-9470] :sdks:java:io:kinesis:test is flaky URL: https://github.com/apache/beam/pull/11090#discussion_r391300387 ########## File path: sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/ShardReadersPoolTest.java ########## @@ -324,10 +325,15 @@ public void shouldCallRateLimitPolicy() } } + ArgumentCaptor<List<KinesisRecord>> recordsCaptor = ArgumentCaptor.forClass(List.class); + verify(customRateLimitPolicy, atLeastOnce()).onSuccess(recordsCaptor.capture()); + List<List<KinesisRecord>> capturedRecords = recordsCaptor.getAllValues(); + assertThat(capturedRecords).contains( + ImmutableList.of(a, b), + singletonList(c), + singletonList(d), + Collections.emptyList() + ); verify(customRateLimitPolicy).onThrottle(same(e)); - verify(customRateLimitPolicy).onSuccess(eq(ImmutableList.of(a, b))); - verify(customRateLimitPolicy).onSuccess(eq(singletonList(c))); - verify(customRateLimitPolicy).onSuccess(eq(singletonList(d))); Review comment: I disagree (I’m not a committer). We just revealed a bug, which is very hard to reproduce. @aromanenko-dev > @RepeatedTest(10000) and some hacks to run it on Junit5 Would you share this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 401827) Time Spent: 3h (was: 2h 50m) > :sdks:java:io:kinesis:test is flaky > ----------------------------------- > > Key: BEAM-9470 > URL: https://issues.apache.org/jira/browse/BEAM-9470 > Project: Beam > Issue Type: Test > Components: io-java-kinesis > Reporter: Etienne Chauchot > Assignee: Jonothan Farr > Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > [https://scans.gradle.com/s/b4jmmu72ku5jc/console-log?task=:sdks:java:io:kinesis:test] -- This message was sent by Atlassian Jira (v8.3.4#803005)