[ https://issues.apache.org/jira/browse/BEAM-8374?focusedWorklogId=403253&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403253 ]
ASF GitHub Bot logged work on BEAM-8374: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Mar/20 22:57 Start Date: 13/Mar/20 22:57 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9758: [BEAM-8374] Enable returning missing PublishResult fields in SnsIO.Write URL: https://github.com/apache/beam/pull/9758#issuecomment-598964756 > One last question @lukecwik, would you prefer to apply these changes in amazon-web-services2 in this PR? Or should we take that to a separate PR? That might be a good opportunity to discuss making some improvements to how errors are handled in this IO. In my opinion it's somewhat suboptimal that `IOException`s and the like are handled in the IO but HTTP error responses have to be handled in the caller, for example. I would prefer a separate PR so that people can start using this sooner then later. Also smaller PRs are easier to review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 403253) Time Spent: 10h (was: 9h 50m) > PublishResult returned by SnsIO is missing sdkResponseMetadata and > sdkHttpMetadata > ---------------------------------------------------------------------------------- > > Key: BEAM-8374 > URL: https://issues.apache.org/jira/browse/BEAM-8374 > Project: Beam > Issue Type: Bug > Components: io-java-aws > Affects Versions: 2.13.0, 2.14.0, 2.15.0 > Reporter: Jonothan Farr > Assignee: Jonothan Farr > Priority: Minor > Time Spent: 10h > Remaining Estimate: 0h > > Currently the PublishResultCoder in SnsIO only serializes the messageId field > so the PublishResult returned by Beam returns null for > getSdkResponseMetadata() and getSdkHttpMetadata(). This makes it impossible > to check the HTTP status for errors, which is necessary since this is not > handled in SnsIO. -- This message was sent by Atlassian Jira (v8.3.4#803005)