[
https://issues.apache.org/jira/browse/BEAM-9470?focusedWorklogId=404089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404089
]
ASF GitHub Bot logged work on BEAM-9470:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/20 16:52
Start Date: 16/Mar/20 16:52
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on issue #11090: [BEAM-9470]
:sdks:java:io:kinesis:test is flaky
URL: https://github.com/apache/beam/pull/11090#issuecomment-599641222
> The test case waits for 5 elements from shardReadersPool:
@suztomo I think I disagree here - `fetchedRecords` will contain only 4
elements maximum. And they always will be only "a", "b", "c" and "d" but maybe
in different order. Empty records won't be returned by
`shardReadersPool.nextRecord()`, however they will be passed to
`rateLimiter.onSuccess()` as an argument (which is unnecessary I think).
Let me explain how I understand this test. @jfarr , please correct me if I'm
wrong. Actually, we need this loop running until `fetchedRecords.size() < 4`
only to make sure that 2 reader threads did read all these 4 records. Than we
assert that `rateLimiter` worked correctly during this since this is a real
purpose of this test.
I think that new version of this test with timeout (last commit) should be
fine. I tested it locally several times with 10k runs and no fails for the
moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 404089)
Time Spent: 7h 50m (was: 7h 40m)
> :sdks:java:io:kinesis:test is flaky
> -----------------------------------
>
> Key: BEAM-9470
> URL: https://issues.apache.org/jira/browse/BEAM-9470
> Project: Beam
> Issue Type: Test
> Components: io-java-kinesis
> Reporter: Etienne Chauchot
> Assignee: Jonothan Farr
> Priority: Major
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> [https://scans.gradle.com/s/b4jmmu72ku5jc/console-log?task=:sdks:java:io:kinesis:test]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
