[ https://issues.apache.org/jira/browse/BEAM-3301?focusedWorklogId=405879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405879 ]
ASF GitHub Bot logged work on BEAM-3301: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/Mar/20 00:58 Start Date: 19/Mar/20 00:58 Worklog Time Spent: 10m Work Description: lostluck commented on pull request #11144: [BEAM-3301] Perform SDF validation (missing RestrictionTrackers). URL: https://github.com/apache/beam/pull/11144#discussion_r394728377 ########## File path: sdks/go/pkg/beam/core/graph/fn_test.go ########## @@ -470,6 +542,169 @@ func (fn *BadDoFnAmbiguousSideInput) StartBundle(bool) { func (fn *BadDoFnAmbiguousSideInput) FinishBundle(bool) { } +// Examples of correct SplittableDoFn signatures + +type RestT struct{} + +type GoodSdf struct { Review comment: Shouldn't the ProcessElement method be adjusted here for the Restriction tracker parameter for a "GoodSdf" ? I guess technically if we don't care about dynamic splitting at all, it should be allowed. It's not unreasonable to prevent it until we have the right idea how to do that, but if so, lets put a TODO in here somewhere to make the intent explicit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 405879) Time Spent: 5h 40m (was: 5.5h) > Go SplittableDoFn support > ------------------------- > > Key: BEAM-3301 > URL: https://issues.apache.org/jira/browse/BEAM-3301 > Project: Beam > Issue Type: Improvement > Components: sdk-go > Reporter: Henning Rohde > Assignee: Daniel Oliveira > Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > > SDFs will be the only way to add streaming and liquid sharded IO for Go. > Design doc: https://s.apache.org/splittable-do-fn -- This message was sent by Atlassian Jira (v8.3.4#803005)