[
https://issues.apache.org/jira/browse/BEAM-9542?focusedWorklogId=405899&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405899
]
ASF GitHub Bot logged work on BEAM-9542:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/20 01:36
Start Date: 19/Mar/20 01:36
Worklog Time Spent: 10m
Work Description: suztomo commented on pull request #11168: [BEAM-9542]
Limit and clarify the effect of "force" in Java build
URL: https://github.com/apache/beam/pull/11168#discussion_r394739760
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -75,6 +75,7 @@ dependencies {
compile library.java.proto_google_common_protos
compile library.java.protobuf_java
compile library.java.slf4j_api
+ compileOnly library.java.hamcrest_library // should not appear in users'
class path
Review comment:
This module's `org.apache.beam.sdk.io.gcp.pubsub.TestPubsub` in "main" (not
test) uses Hamcrest's matchers. Therefore declaring the dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 405899)
Time Spent: 1.5h (was: 1h 20m)
> Where the BeamModulePlugin's force is needed?
> ---------------------------------------------
>
> Key: BEAM-9542
> URL: https://issues.apache.org/jira/browse/BEAM-9542
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Tomo Suzuki
> Assignee: Tomo Suzuki
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Followup of https://github.com/apache/beam/pull/11156#discussion_r394408735
> {noformat}
> > Task :sdks:java:core:compileTestJava FAILED
> /Users/suztomo/beam/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/DeduplicateTest.java:21:
> error: cannot find symbol
> import static org.junit.Assert.assertThrows;
> ^
> symbol: static assertThrows
> location: class
> /Users/suztomo/beam/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/splittabledofn/WatermarkEstimatorsTest.java:21:
> error: cannot find symbol
> import static org.junit.Assert.assertThrows;
> ^
> symbol: static assertThrows
> location: class
> Note: Some input files use or override a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> 2 errors
> <====---------> 36% EXECUTING [19m 37s]
> {noformat}
> Memo for my Mac:
> {noformat}
> suztomo-macbookpro44% ./gradlew -p sdks/java check -x
> extensions:sql:zetasql:check -x harness:test -x io:jdbc:test -x
> io:kafka:test -x io:solr:test -x core:test
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
