[ https://issues.apache.org/jira/browse/BEAM-8173?focusedWorklogId=406156&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406156 ]
ASF GitHub Bot logged work on BEAM-8173: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/Mar/20 13:09 Start Date: 19/Mar/20 13:09 Worklog Time Spent: 10m Work Description: piotr-szuberski commented on issue #11137: [BEAM-8173] Fix shadowing the actual failure exception in Filesystems… URL: https://github.com/apache/beam/pull/11137#issuecomment-601161707 @mwalenia at least the tests passed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 406156) Time Spent: 3h 20m (was: 3h 10m) > Filesystems.matchSingleFileSpec throws away the actual failure exception > ------------------------------------------------------------------------ > > Key: BEAM-8173 > URL: https://issues.apache.org/jira/browse/BEAM-8173 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Kenneth Knowles > Assignee: Piotr Szuberski > Priority: Major > Labels: easyfix, starter > Time Spent: 3h 20m > Remaining Estimate: 0h > > At [1] the result of a non-OK match causes an exception to be thrown. But the > exception does not include the actual cause of the failure, so it cannot be > efficiently debugged. It appears that the design of MatchResult is that it > should call metadata() without bothering to check status, so that the > underlying exception can be re-raised and caught and put in the chain of > causes, as it should be. > [1] > https://github.com/apache/beam/blob/c2f0d282337f3ae0196a7717712396a5a41fdde1/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileSystems.java#L190 -- This message was sent by Atlassian Jira (v8.3.4#803005)