[
https://issues.apache.org/jira/browse/BEAM-8910?focusedWorklogId=406748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406748
]
ASF GitHub Bot logged work on BEAM-8910:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/20 03:15
Start Date: 20/Mar/20 03:15
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #11086: [BEAM-8910]
Make custom BQ source read from Avro
URL: https://github.com/apache/beam/pull/11086#discussion_r395422570
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py
##########
@@ -236,11 +251,12 @@ def create_table(cls, table_name):
cls.bigquery_client.insert_rows(
cls.project, cls.dataset_id, table_name, table_data)
- def get_expected_data(self):
+ def get_expected_data(self, native=True):
+ byts = b'\xab\xac'
expected_row = {
'float': 0.33,
'numeric': Decimal('10'),
- 'bytes': base64.b64encode(b'\xab\xac'),
+ 'bytes': base64.b64encode(byts) if native else byts,
Review comment:
How intuitive will this behavior be to users? should't the output be
consistent?
If we decide to keep it, how will this be documented?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 406748)
Time Spent: 2h 40m (was: 2.5h)
> Use AVRO instead of JSON in BigQuery bounded source.
> ----------------------------------------------------
>
> Key: BEAM-8910
> URL: https://issues.apache.org/jira/browse/BEAM-8910
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Kamil Wasilewski
> Assignee: Pablo Estrada
> Priority: Minor
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> The proposed BigQuery bounded source in Python SDK (see PR:
> [https://github.com/apache/beam/pull/9772)] uses a BigQuery export job to
> take a snapshot of the table and read from each produced JSON file. A
> performance improvement can be gain by switching to AVRO instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
