[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=406768&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406768
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/20 03:39
Start Date: 20/Mar/20 03:39
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11177: [BEAM-9562]
Add Timer to Elements proto representation.
URL: https://github.com/apache/beam/pull/11177#discussion_r395426182
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -533,8 +538,33 @@ message Elements {
bytes data = 3;
}
+ // Represent the encoded user timer for a given instruction, transform and
+ // timer id.
+ message Timer {
+ // (Required) A reference to an active instruction request with the given
+ // instruction id.
+ string instruction_id = 1;
+ // (Required) A definition representing a consumer or producer of this
data.
+ // If received by a harness, this represents the consumer within that
+ // harness that should consume these bytes. If sent by a harness, this
+ // represents the producer of these bytes.
+ string transform_id = 2;
+ // (Optional) The local timer name which can be mapped to
+ // timer specification.
+ string timer_id = 3;
Review comment:
```suggestion
string timer_id = 3;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 406768)
Time Spent: 20m (was: 10m)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
