[
https://issues.apache.org/jira/browse/BEAM-7923?focusedWorklogId=407229&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407229
]
ASF GitHub Bot logged work on BEAM-7923:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/20 20:47
Start Date: 20/Mar/20 20:47
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11174: [BEAM-7923]
Pop failed transform in CombineGlobally
URL: https://github.com/apache/beam/pull/11174#discussion_r395882293
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1811,6 +1811,8 @@ def add_input_types(transform):
return view
else:
if pcoll.windowing.windowfn != GlobalWindows():
+ # Remove the broken transform when running into value error.
+ pcoll.pipeline.transforms_stack.pop()
Review comment:
This is not the right place to pop this (internal) stack. Instead, we should
popping from the stack in a finally clause of a try block that pushes to the
stack. (Alternatively, we could manage the stack with a Python context, but
that might be overkill.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 407229)
Time Spent: 8.5h (was: 8h 20m)
> Interactive Beam
> ----------------
>
> Key: BEAM-7923
> URL: https://issues.apache.org/jira/browse/BEAM-7923
> Project: Beam
> Issue Type: New Feature
> Components: runner-py-interactive
> Reporter: Ning Kang
> Assignee: Ning Kang
> Priority: Major
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> This is the top level ticket for all efforts leveraging [interactive
> Beam|[https://github.com/apache/beam/tree/master/sdks/python/apache_beam/runners/interactive]]
> As the development goes, blocking tickets will be added to this one.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
