[ https://issues.apache.org/jira/browse/BEAM-9454?focusedWorklogId=408286&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408286 ]
ASF GitHub Bot logged work on BEAM-9454: ---------------------------------------- Author: ASF GitHub Bot Created on: 23/Mar/20 20:38 Start Date: 23/Mar/20 20:38 Worklog Time Spent: 10m Work Description: boyuanzz commented on pull request #11060: [BEAM-9454] Create Deduplication transform based on user timer/state URL: https://github.com/apache/beam/pull/11060#discussion_r396742097 ########## File path: sdks/python/apache_beam/transforms/deduplicate_test.py ########## @@ -0,0 +1,168 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# pytype: skip-file + +"""Unit tests for deduplicate transform by using TestStream.""" + +from __future__ import absolute_import + +import unittest + +from nose.plugins.attrib import attr + +import apache_beam as beam +from apache_beam.coders import coders +from apache_beam.testing.test_pipeline import TestPipeline +from apache_beam.testing.test_stream import TestStream +from apache_beam.testing.util import assert_that +from apache_beam.testing.util import equal_to +from apache_beam.testing.util import equal_to_per_window +from apache_beam.transforms import deduplicate +from apache_beam.transforms import window +from apache_beam.utils.timestamp import Duration +from apache_beam.utils.timestamp import Timestamp + + +# TestStream is only supported in streaming pipeline. The Deduplicate transform +# also requires Timer support. Sickbaying this testsuite until dataflow runner +# supports both TestStream and user timer. +@attr('ValidatesRunner', 'sickbay-batch', 'sickbay-streaming') Review comment: The 'sickbay-batch' and 'sickbay-streaming' is only used by dataflow suite now. And unfortunately, I don't we have runners supporting these python test now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 408286) Time Spent: 5h 20m (was: 5h 10m) > Add Deduplication transform for SDF > ----------------------------------- > > Key: BEAM-9454 > URL: https://issues.apache.org/jira/browse/BEAM-9454 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core, sdk-py-core > Reporter: Boyuan Zhang > Priority: Major > Time Spent: 5h 20m > Remaining Estimate: 0h > > When SDF is used as a source-like operation, it's necessary to provide a > default Deduplication transform for the SDF user to deduplicate values by > certain unique id. -- This message was sent by Atlassian Jira (v8.3.4#803005)