[ 
https://issues.apache.org/jira/browse/BEAM-9548?focusedWorklogId=408977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408977
 ]

ASF GitHub Bot logged work on BEAM-9548:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Mar/20 17:47
            Start Date: 24/Mar/20 17:47
    Worklog Time Spent: 10m 
      Work Description: rohdesamuel commented on pull request #11163: 
[BEAM-9548] Add better error handling to the TestStreamServiceController
URL: https://github.com/apache/beam/pull/11163#discussion_r397347169
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/interactive_runner.py
 ##########
 @@ -170,8 +170,13 @@ def run_pipeline(self, pipeline, options):
               user_pipeline)):
         streaming_cache_manager = ie.current_env().cache_manager()
         if streaming_cache_manager:
+
+          def exception_handler(e):
+            _LOGGER.error(str(e))
 
 Review comment:
   For here, we this is caught at the TestStreamService level and for the same 
reason, we just log the error so that it's easier for the user to understand. 
Because it's caught at the service level, it means that we have already stopped 
processing.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 408977)
    Time Spent: 50m  (was: 40m)

> Bad error handling with errors from TestStreamService when using Interactive 
> Beam
> ---------------------------------------------------------------------------------
>
>                 Key: BEAM-9548
>                 URL: https://issues.apache.org/jira/browse/BEAM-9548
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-py-interactive
>            Reporter: Sam Rohde
>            Assignee: Sam Rohde
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The error handling when an error is generated on the GRPC server side is very 
> verbose and hides the problem.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to