[
https://issues.apache.org/jira/browse/BEAM-9605?focusedWorklogId=409503&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409503
]
ASF GitHub Bot logged work on BEAM-9605:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/20 13:27
Start Date: 25/Mar/20 13:27
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on pull request #11218:
[BEAM-9605] BIP-1: Rename setRowOption to setOption on Option builder
URL: https://github.com/apache/beam/pull/11218
Rename setRowOption to setOption on Option builder as setRowOption
name is too confusing.
It sets an option as a Row, not an option on a Row. Using setOption
is better and doesn't conflict with the other setOption with 3
parameters and explicit type.
This commit also removed left over @Nullable annotations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 409503)
Remaining Estimate: 0h
Time Spent: 10m
> BIP-1: Rename setRowOption to setOption on Option builder
> ----------------------------------------------------------
>
> Key: BEAM-9605
> URL: https://issues.apache.org/jira/browse/BEAM-9605
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Rename setRowOption to setOption on Option builder as setRowOption name is
> too confusing.
> It sets an option as a Row, not an option on a Row. Using setOption is better
> and doesn't conflict with the other setOption with 3 parameters and explicit
> type.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
