[
https://issues.apache.org/jira/browse/BEAM-4150?focusedWorklogId=410510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410510
]
ASF GitHub Bot logged work on BEAM-4150:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/20 18:52
Start Date: 26/Mar/20 18:52
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #11222: [BEAM-4150] Don't
window PCollection coders.
URL: https://github.com/apache/beam/pull/11222#issuecomment-604619996
As forusing the input/output PCollection names, rather than the GRPC ids,
that's a good question. Things are structured this way is mostly to follow the
existing code, where things are indexed by these PCollections. In particular,
... -> pcIn -> GBK -> pcOut -> ...
gets replaced by
... -> pcIn -> GrpcOut
GrpcIn -> pcOut -> ...
but the original GBK transform itself is kept around (with its references to
pcIn and pcOut--it's the object that "connects" the two) to construct the
appropriate grouping buffer. This could be refactored, and may be if GBK
becomes a full-fledged operator to make it more streamy, but that seemed out of
scope for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 410510)
Time Spent: 8h (was: 7h 50m)
> Standardize use of PCollection coder proto attribute
> ----------------------------------------------------
>
> Key: BEAM-4150
> URL: https://issues.apache.org/jira/browse/BEAM-4150
> Project: Beam
> Issue Type: Task
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Luke Cwik
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> In some places it's expected to be a WindowedCoder, in others the raw
> ElementCoder. We should use the same convention (decided in discussion to be
> the raw ElementCoder) everywhere. The WindowCoder can be pulled out of the
> attached windowing strategy, and the input/output ports should specify the
> encoding directly rather than read the adjacent PCollection coder fields.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
