[ https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=410637&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410637 ]
ASF GitHub Bot logged work on BEAM-4374: ---------------------------------------- Author: ASF GitHub Bot Created on: 26/Mar/20 21:20 Start Date: 26/Mar/20 21:20 Worklog Time Spent: 10m Work Description: lukecwik commented on pull request #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398899707 ########## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/fn/control/ElementCountMonitoringInfoToCounterUpdateTransformer.java ########## @@ -95,7 +99,12 @@ public CounterUpdate transform(MonitoringInfo monitoringInfo) { return null; } - long value = monitoringInfo.getMetric().getCounterData().getInt64Value(); + long value; + try { + value = VARINT_CODER.decode(monitoringInfo.getPayload().newInput()); Review comment: Done here an elsewhere. I introduced a MonitoringInfoEncodings class with the convenience methods for the currently used encodings. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 410637) Time Spent: 31h 50m (was: 31h 40m) > Update existing metrics in the FN API to use new Metric Schema > -------------------------------------------------------------- > > Key: BEAM-4374 > URL: https://issues.apache.org/jira/browse/BEAM-4374 > Project: Beam > Issue Type: New Feature > Components: beam-model > Reporter: Alex Amato > Priority: Major > Time Spent: 31h 50m > Remaining Estimate: 0h > > Update existing metrics to use the new proto and cataloging schema defined in: > [_https://s.apache.org/beam-fn-api-metrics_] > * Check in new protos > * Define catalog file for metrics > * Port existing metrics to use this new format, based on catalog > names+metadata -- This message was sent by Atlassian Jira (v8.3.4#803005)