[ https://issues.apache.org/jira/browse/BEAM-9573?focusedWorklogId=410686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410686 ]
ASF GitHub Bot logged work on BEAM-9573: ---------------------------------------- Author: ASF GitHub Bot Created on: 26/Mar/20 22:58 Start Date: 26/Mar/20 22:58 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #11220: [BEAM-9573][release-2.20] Correct computing of watermark hold for timer output timestamp URL: https://github.com/apache/beam/pull/11220#issuecomment-604729513 Great! all tests have passed! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 410686) Time Spent: 8h 10m (was: 8h) > Watermark hold for timer output timestamp is not computed correctly > ------------------------------------------------------------------- > > Key: BEAM-9573 > URL: https://issues.apache.org/jira/browse/BEAM-9573 > Project: Beam > Issue Type: Bug > Components: runner-flink > Affects Versions: 2.20.0 > Reporter: Maximilian Michels > Assignee: Maximilian Michels > Priority: Blocker > Fix For: 2.20.0 > > Time Spent: 8h 10m > Remaining Estimate: 0h > > With the introduction of timer output timestamp, a new watermark hold had > been added to the Flink Runner. The watermark computation works on the keyed > state backend which computes a key-scoped watermark hold and not the desired > operator-wide watermark hold. > Computation: > https://github.com/apache/beam/blob/b564239081e9351c56fb0e7d263495b95dd3f8f3/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java#L1140 > Key-scoped state: > https://github.com/apache/beam/blob/b564239081e9351c56fb0e7d263495b95dd3f8f3/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java#L1130 > We need to change this to operate on all keys. This has to be done before > fixing BEAM-9566. -- This message was sent by Atlassian Jira (v8.3.4#803005)