[ 
https://issues.apache.org/jira/browse/BEAM-9642?focusedWorklogId=414232&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414232
 ]

ASF GitHub Bot logged work on BEAM-9642:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Apr/20 18:53
            Start Date: 01/Apr/20 18:53
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on pull request #11257: [BEAM-9642] 
Create runtime invokers for SDF methods.
URL: https://github.com/apache/beam/pull/11257#discussion_r401836095
 
 

 ##########
 File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers_test.go
 ##########
 @@ -0,0 +1,282 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package exec
+
+import (
+       "github.com/apache/beam/sdks/go/pkg/beam/core/graph"
+       "github.com/google/go-cmp/cmp"
+       "testing"
+)
+
+func init() {
 
 Review comment:
   remove empty init block?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 414232)
    Time Spent: 1h  (was: 50m)

> Add SDF execution-time runners
> ------------------------------
>
>                 Key: BEAM-9642
>                 URL: https://issues.apache.org/jira/browse/BEAM-9642
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Adds execution-time SDF runner units to the exec package, and any unit tests 
> + helpers required.
> This is needed to get the expanded SDF URNs to execute in the runner harness.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to