[
https://issues.apache.org/jira/browse/BEAM-9618?focusedWorklogId=414354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414354
]
ASF GitHub Bot logged work on BEAM-9618:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/20 22:52
Start Date: 01/Apr/20 22:52
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11235: [BEAM-9618]
Pull bundle descriptors.
URL: https://github.com/apache/beam/pull/11235#discussion_r401943249
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClientPoolService.java
##########
@@ -105,12 +105,38 @@ public static FnApiControlClientPoolService
offeringClientsToPool(
return newClient.asResponseObserver();
}
+ @Override
+ public void getProcessBundleDescriptor(
+ BeamFnApi.GetProcessBundleDescriptorRequest request,
+ StreamObserver<BeamFnApi.ProcessBundleDescriptor> responseObserver) {
+ final String workerId = headerAccessor.getSdkWorkerId();
+ if (Strings.isNullOrEmpty(workerId)) {
+ // TODO(BEAM-4149): Enforce proper worker id.
+ LOG.warn("No worker_id header provided in getProcessBundleDescriptor
request");
Review comment:
Since this is a new method, we should force all users to supply it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 414354)
Time Spent: 20m (was: 10m)
> Allow SDKs to pull process bundle descriptors.
> ----------------------------------------------
>
> Key: BEAM-9618
> URL: https://issues.apache.org/jira/browse/BEAM-9618
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
