[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=414422&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414422
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/20 01:52
Start Date: 02/Apr/20 01:52
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #11185:
[BEAM-8019] Updates Python SDK to handle remote SDK coders and preserve tags
added by remote SDKs and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r400604613
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -995,10 +1044,13 @@ def run_ParDo(self, transform_node, options):
# The assumption here is that all outputs will have the same typehint
# and coder as the main output. This is certainly the case right now
# but conceivably it could change in the future.
+ encoding = self._get_encoded_output_coder(
+ transform_node,
+ output_tag=side_tag) if external_transform else step.encoding
Review comment:
We don't have to. Previously we were using same encoding for all outputs for
Python but seems like we can just generalize this without issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 414422)
Time Spent: 13h 50m (was: 13h 40m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 13h 50m
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
