[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=415225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415225
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/20 00:53
Start Date: 03/Apr/20 00:53
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11185: [BEAM-8019]
Updates Python SDK to handle remote SDK coders and preserve tags added by
remote SDKs and propagate restriction coders.
URL: https://github.com/apache/beam/pull/11185#discussion_r402668985
##########
File path: sdks/python/apache_beam/coders/coders.py
##########
@@ -370,7 +370,8 @@ def from_runner_api(cls, coder_proto, context):
except Exception:
if context.allow_proto_holders:
# ignore this typing scenario for now, since it can't be easily tracked
- return RunnerAPICoderHolder(coder_proto) # type: ignore
+ return ExternalCoder(
Review comment:
Thanks. I think it'd be cleaner to just put this `if` instead of the `try`,
and not have a broadly-catching "except Exception" block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 415225)
Time Spent: 15h (was: 14h 50m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 15h
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
