[
https://issues.apache.org/jira/browse/BEAM-3097?focusedWorklogId=415758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415758
]
ASF GitHub Bot logged work on BEAM-3097:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/20 21:43
Start Date: 03/Apr/20 21:43
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #11244: [BEAM-3097]
_ReadFromBigQuery supports valueprovider for table
URL: https://github.com/apache/beam/pull/11244#discussion_r403350713
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -657,6 +664,10 @@ def estimate_size(self):
kms_key=self.kms_key)
size = int(job.statistics.totalBytesProcessed)
return size
+ else:
+ # Size estimation is best effort. We return 0 as we have no
+ # access to the query that we're running.
+ return 0
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 415758)
Time Spent: 2h 40m (was: 2.5h)
> Allow BigQuerySource to take a ValueProvider as a table input.
> --------------------------------------------------------------
>
> Key: BEAM-3097
> URL: https://issues.apache.org/jira/browse/BEAM-3097
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Ed Mothershaw
> Priority: Minor
> Original Estimate: 2h
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> In file sdks/python/apache_beam/io/gcp/bigquery.py, class BigQuery, line 389.
> When a ValueProvider is input as table the script will fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
