[ https://issues.apache.org/jira/browse/BEAM-8603?focusedWorklogId=416039&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-416039 ]
ASF GitHub Bot logged work on BEAM-8603: ---------------------------------------- Author: ASF GitHub Bot Created on: 04/Apr/20 22:06 Start Date: 04/Apr/20 22:06 Worklog Time Spent: 10m Work Description: TheNeuralBit commented on pull request #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#discussion_r403515620 ########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/SqlTransform.java ########## @@ -271,6 +275,19 @@ static Builder builder() { abstract Builder setDefaultTableProvider(@Nullable String defaultTableProvider); abstract SqlTransform build(); + + @Override + public PTransform<PInput, PCollection<Row>> buildExternal( + External.Configuration configuration) { + return builder() Review comment: To be general purpose we'd also need a way to define a mapping for non-primitive values e.g. JSON string -> `QueryParameters`. This is sort of like logical types, but we only need one direction. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 416039) Time Spent: 7h 40m (was: 7.5h) > Add Python SqlTransform MVP > --------------------------- > > Key: BEAM-8603 > URL: https://issues.apache.org/jira/browse/BEAM-8603 > Project: Beam > Issue Type: Improvement > Components: dsl-sql, sdk-py-core > Reporter: Brian Hulette > Assignee: Brian Hulette > Priority: Major > Time Spent: 7h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)