[
https://issues.apache.org/jira/browse/BEAM-9727?focusedWorklogId=419642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419642
]
ASF GitHub Bot logged work on BEAM-9727:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 18:52
Start Date: 09/Apr/20 18:52
Worklog Time Spent: 10m
Work Description: ananvay commented on pull request #11355: [BEAM-9727]
Automatically set required experiment flags for dataflow runner v2.
URL: https://github.com/apache/beam/pull/11355#discussion_r406409214
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -566,6 +572,17 @@ def run_pipeline(self, pipeline, options):
result.metric_results = self._metrics
return result
+ def _maybe_add_unified_worker_missing_options(self, options):
+ # set default beam_fn_api and use_unified_worker experiment if
+ # 'use_runner_v2' experiment flag exists, no-op otherwise.
+ experiments = options.view_as(DebugOptions).experiments or []
+ if 'use_runner_v2' in experiments:
+ if not 'beam_fn_api' in experiments:
Review comment:
can we do it for batch bq source as well? I don't think the UW can support
the native BQ source...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 419642)
Time Spent: 1.5h (was: 1h 20m)
> Auto populate required feature experiment flags for enable dataflow runner v2
> -----------------------------------------------------------------------------
>
> Key: BEAM-9727
> URL: https://issues.apache.org/jira/browse/BEAM-9727
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
