[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=419804&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419804
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 21:37
Start Date: 09/Apr/20 21:37
Worklog Time Spent: 10m
Work Description: alanmyrvold commented on pull request #11243:
[BEAM-9136]Add licenses for dependencies for Java
URL: https://github.com/apache/beam/pull/11243#discussion_r406488881
##########
File path: sdks/java/container/build.gradle
##########
@@ -68,6 +73,28 @@ golang {
}
}
+// this is a workaround to call generateLicenseReport task from project root
directory.
+// generateLicenseReport does not return correct dependency list when not
called from the root.
+task generateThirdPartyLicenses(type: Exec) {
+ workingDir project.rootProject.projectDir
+ commandLine './sdks/java/container/license_scripts/license_script.sh'
Review comment:
Why does the gradle task need to start a shell script that runs gradle? Can
the gradle task be a dependency instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 419804)
Time Spent: 20h 10m (was: 20h)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 20h 10m
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
