[ https://issues.apache.org/jira/browse/BEAM-9733?focusedWorklogId=422057&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422057 ]
ASF GitHub Bot logged work on BEAM-9733: ---------------------------------------- Author: ASF GitHub Bot Created on: 14/Apr/20 14:17 Start Date: 14/Apr/20 14:17 Worklog Time Spent: 10m Work Description: mxm commented on issue #11362: [BEAM-9733] Always let ImpulseSourceFunction emit a final watermark URL: https://github.com/apache/beam/pull/11362#issuecomment-613469832 Unrelated test failure: ``` 15:55:21 FAILURE: Build failed with an exception. 15:55:21 15:55:21 * What went wrong: 15:55:21 Execution failed for task ':sdks:java:container:generateThirdPartyLicenses'. 15:55:21 > Process 'command './sdks/java/container/license_scripts/license_script.sh'' finished with non-zero exit value 1 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 422057) Time Spent: 2h 40m (was: 2.5h) > ImpulseSourceFunction does not emit a final watermark > ----------------------------------------------------- > > Key: BEAM-9733 > URL: https://issues.apache.org/jira/browse/BEAM-9733 > Project: Beam > Issue Type: Bug > Components: runner-flink > Reporter: Maximilian Michels > Assignee: Maximilian Michels > Priority: Critical > Fix For: 2.21.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > The Flink Runner's {{ImpulseSourceFunction}} does not emit a final watermark, > unless {{--shutdownSourcesOnFinalWatermark}} flag has been specified (the > flag is used in tests to shutdown the pipeline after reading all data). Most > pipelines will be long-running and thus do not specify the flag. > Not sending out the final watermark causes GroupByKey to hold back the data > of event time windows until the pipeline is shut down (the final watermark is > always emitted on pipeline shutdown which is why using the above flag works). -- This message was sent by Atlassian Jira (v8.3.4#803005)