[
https://issues.apache.org/jira/browse/BEAM-9729?focusedWorklogId=422784&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422784
]
ASF GitHub Bot logged work on BEAM-9729:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/20 15:35
Start Date: 15/Apr/20 15:35
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11358: [BEAM-9729]
Runner-side bundle registration cleanup.
URL: https://github.com/apache/beam/pull/11358#discussion_r408935328
##########
File path:
runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClientTest.java
##########
@@ -573,7 +577,7 @@ public void
handleCleanupWithStateWhenAwaitingOnClosingOutputReceivers() throws
@Test
public void verifyCacheTokensAreUsedInNewBundleRequest() throws
InterruptedException {
when(fnApiControlClient.handle(any(BeamFnApi.InstructionRequest.class)))
- .thenReturn(createRegisterResponse());
+ .thenReturn(createAnyResponse());
Review comment:
Since this function is only used once, you might want to inline the contents
of the function here for readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 422784)
Time Spent: 1.5h (was: 1h 20m)
> Cleanup bundle registration now that SDKs can pull.
> ---------------------------------------------------
>
> Key: BEAM-9729
> URL: https://issues.apache.org/jira/browse/BEAM-9729
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Once all runners (in particular dataflow) support pull descriptors, we can
> clean things up by removing the push registration code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
