[
https://issues.apache.org/jira/browse/BEAM-9650?focusedWorklogId=422800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422800
]
ASF GitHub Bot logged work on BEAM-9650:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Apr/20 15:54
Start Date: 15/Apr/20 15:54
Worklog Time Spent: 10m
Work Description: soyrice commented on pull request #11415: [BEAM-9650]
Cleanup documentation on side inputs patterns
URL: https://github.com/apache/beam/pull/11415#discussion_r408951043
##########
File path: website/src/documentation/patterns/side-inputs.md
##########
@@ -46,29 +54,36 @@ For instance, the following code sample uses a `Map` to
create a `DoFn`. The `Ma
{% github_sample
/apache/beam/blob/master/examples/java/src/main/java/org/apache/beam/examples/snippets/Snippets.java
tag:SideInputPatternSlowUpdateGlobalWindowSnip1
%}
```
+```py
+No sample present.
+```
## Slowly updating side input using windowing
-You can read side input pcollection periodically into distinct windows.
-Later, when you apply side input to your main input, windows will be matched
automatically 1:1.
-This way, you can guarantee side input consistency on the duration of the
single window.
+You can read side input data periodically into distinct PCollection windows.
+Later, when you apply the side input to your main input, each main input
+window is automatically matched to a single side input window.
+This guarantees consistency on the duration of the single window,
+meaning that each window on the main input will be matched to a single
+version of side input data.
-To do this, you can utilize PeriodicSequence PTransform that will generate
infinite sequence
-of elements with some real-time period:
+Described approach can be implemented using combination of
+PeriodicSequence or PeriodicImpulse PTransforms and SDF Read or ReadAll
+PTransforms:
-1. Use the PeriodicImpulse transform to generate windowed periodic sequence.
-
- a. MAX_TIMESTAMP can be replaced with some closer boundary if you want to
stop generating elements at some point.
+1. Use the PeriodicImpulse or PeriodicSequence PTransform to generate an
+infinite sequence of elements at required processing time intervals and assign
+them to separate windows.
1. Read data using Read operation triggered by arrival of PCollection element.
Review comment:
I see you marked the previous comment here as resolved but I don't see any
changes to this line. Was that intended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 422800)
> Add consistent slowly changing side inputs support
> --------------------------------------------------
>
> Key: BEAM-9650
> URL: https://issues.apache.org/jira/browse/BEAM-9650
> Project: Beam
> Issue Type: Bug
> Components: io-ideas
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Add implementation for slowly changing dimentions based on [design
> doc](https://docs.google.com/document/d/1LDY_CtsOJ8Y_zNv1QtkP6AGFrtzkj1q5EW_gSChOIvg/edit]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
