[ 
https://issues.apache.org/jira/browse/BEAM-9577?focusedWorklogId=425982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425982
 ]

ASF GitHub Bot logged work on BEAM-9577:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Apr/20 01:38
            Start Date: 22/Apr/20 01:38
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on a change in pull request #11489:
URL: https://github.com/apache/beam/pull/11489#discussion_r412605572



##########
File path: sdks/go/pkg/beam/artifact/materialize.go
##########
@@ -128,6 +128,11 @@ func (a artifact) retrieve(ctx context.Context, dest 
string) error {
                return errors.Wrapf(err, "failed to stat %v", filename)
        }
 
+       err = os.MkdirAll(filepath.Dir(filename), os.ModePerm)
+       if err != nil {

Review comment:
       Nit: could be inlined into the if (and change the = to := ) but it's not 
worth blocking for.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 425982)
    Time Spent: 18.5h  (was: 18h 20m)

> Update artifact staging and retrieval protocols to be dependency aware.
> -----------------------------------------------------------------------
>
>                 Key: BEAM-9577
>                 URL: https://issues.apache.org/jira/browse/BEAM-9577
>             Project: Beam
>          Issue Type: Improvement
>          Components: beam-model
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: Major
>          Time Spent: 18.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to