[
https://issues.apache.org/jira/browse/BEAM-9831?focusedWorklogId=429125&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429125
]
ASF GitHub Bot logged work on BEAM-9831:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/20 16:38
Start Date: 30/Apr/20 16:38
Worklog Time Spent: 10m
Work Description: jaketf commented on a change in pull request #11538:
URL: https://github.com/apache/beam/pull/11538#discussion_r418142864
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##########
@@ -475,7 +497,14 @@ public void initClient() throws IOException {
public void listMessages(ProcessContext context) throws IOException {
String hl7v2Store = context.element();
// Output all elements of all pages.
- this.client.getHL7v2MessageStream(hl7v2Store,
this.filter).forEach(context::output);
+ HttpHealthcareApiClient.HL7v2MessagePages pages =
+ new HttpHealthcareApiClient.HL7v2MessagePages(client, hl7v2Store,
this.filter);
+ long reqestTime = Instant.now().getMillis();
Review comment:
This is to track latency of list pagination requests in a metric
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 429125)
Time Spent: 2h (was: 1h 50m)
> HL7v2IO Improvements
> --------------------
>
> Key: BEAM-9831
> URL: https://issues.apache.org/jira/browse/BEAM-9831
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Jacob Ferriero
> Assignee: Jacob Ferriero
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> # HL7v2MessageCoder constructor should be public for use by end users
> # Currently HL7v2IO.ListHL7v2Messages blocks on pagination through list
> messages results before emitting any output data elements (due to high fan
> out from a single input element). We should add early firings so that
> downstream processing can proceed on early pages while later pages are still
> being scrolled through.
> # We should drop all output only fields of HL7v2Message and only keep data
> and labels when calling ingestMessages, rather than expecting the user to do
> this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
