[ 
https://issues.apache.org/jira/browse/BEAM-7554?focusedWorklogId=429629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429629
 ]

ASF GitHub Bot logged work on BEAM-7554:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/May/20 19:51
            Start Date: 01/May/20 19:51
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on a change in pull request 
#11456:
URL: https://github.com/apache/beam/pull/11456#discussion_r418708682



##########
File path: 
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/MillisInstant.java
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.schemas.logicaltypes;
+
+import org.joda.time.Instant;
+import org.joda.time.ReadableInstant;
+
+/** A timestamp represented as milliseconds since the epoch. */
+public class MillisInstant extends MillisType<ReadableInstant> {
+  public static final String IDENTIFIER = 
"beam:logical_type:millis_instant:v1";

Review comment:
       @reuvenlax what do you think about making this type (and maybe 
NanosInstant as well) parameterized by timezone?
   
   The [arrow 
approach](https://github.com/apache/arrow/blob/master/format/Schema.fbs#L178) 
seems useful: un-specified timezone indicates time-zone naive (e.g. joda time 
Instant), otherwise time zone parameter should reference a value in tzdata (and 
would map to joda time DateTime).
   
   cc: @alexvanboxel 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 429629)
    Time Spent: 1h  (was: 50m)

> datetime and decimal should be logical types
> --------------------------------------------
>
>                 Key: BEAM-7554
>                 URL: https://issues.apache.org/jira/browse/BEAM-7554
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql, sdk-java-core
>            Reporter: Brian Hulette
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently datetime and decimal are implemented as primitive types in the Java 
> SDK. They should be logical types as documented in 
> https://s.apache.org/beam-schemas



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to