[
https://issues.apache.org/jira/browse/BEAM-9383?focusedWorklogId=430490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430490
]
ASF GitHub Bot logged work on BEAM-9383:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/20 02:14
Start Date: 05/May/20 02:14
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r419829659
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -210,56 +209,55 @@ public static Environment createProcessEnvironment(
}
}
- private static List<ArtifactInformation> getArtifacts(List<String>
stagingFiles) {
- Set<String> pathsToStage = Sets.newHashSet(stagingFiles);
+ public static List<ArtifactInformation> getArtifacts(
+ List<String> stagingFiles, StagingFileNameGenerator generator) {
ImmutableList.Builder<ArtifactInformation> artifactsBuilder =
ImmutableList.builder();
- for (String path : pathsToStage) {
+ for (String path : ImmutableSet.copyOf(stagingFiles)) {
Review comment:
`ImmutableSet` preserves the order but I think we don't need to make a
copy here. Will use `LinkedHashSet` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 430490)
Time Spent: 7h (was: 6h 50m)
> Staging Dataflow artifacts from environment
> -------------------------------------------
>
> Key: BEAM-9383
> URL: https://issues.apache.org/jira/browse/BEAM-9383
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 7h
> Remaining Estimate: 0h
>
> Staging Dataflow artifacts from environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
