[ https://issues.apache.org/jira/browse/BEAM-9883?focusedWorklogId=432209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432209 ]
ASF GitHub Bot logged work on BEAM-9883: ---------------------------------------- Author: ASF GitHub Bot Created on: 08/May/20 18:10 Start Date: 08/May/20 18:10 Worklog Time Spent: 10m Work Description: lostluck commented on pull request #11605: URL: https://github.com/apache/beam/pull/11605#issuecomment-625946118 LGTM thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 432209) Time Spent: 50m (was: 40m) > Generalize SDF-validating restrictions > -------------------------------------- > > Key: BEAM-9883 > URL: https://issues.apache.org/jira/browse/BEAM-9883 > Project: Beam > Issue Type: Sub-task > Components: sdk-go > Reporter: Daniel Oliveira > Assignee: Daniel Oliveira > Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > We have some restrictions written for the purpose of validating that SDFs > work in sdf_invokers_test.go, but they can be improved and generalized. The > main improvement is changing the validation approach so that the restriction > keeps track of each method it's had called on it. Then this can be > generalized so that it can be used in upcoming integration tests to validate > which methods are being called. -- This message was sent by Atlassian Jira (v8.3.4#803005)