[
https://issues.apache.org/jira/browse/BEAM-9001?focusedWorklogId=432879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-432879
]
ASF GitHub Bot logged work on BEAM-9001:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/20 22:40
Start Date: 13/May/20 22:40
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#11670:
URL: https://github.com/apache/beam/pull/11670#discussion_r424771303
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -123,20 +123,16 @@ class Pipeline(object):
should be used to designate new names
(e.g. ``input | "label" >> my_transform``).
"""
-
- # TODO: BEAM-9001 - set environment ID in all transforms and allow runners to
- # override.
@classmethod
Review comment:
Probably we can introduce a new visitor and update runners to use that
similar to following ?
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L557
But this is not a blocker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 432879)
Time Spent: 1h (was: 50m)
> Allow setting environment ID to all transforms in the SDK
> ---------------------------------------------------------
>
> Key: BEAM-9001
> URL: https://issues.apache.org/jira/browse/BEAM-9001
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-java-harness, sdk-py-core,
> sdk-py-harness
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Luke Cwik
> Priority: Blocker
> Fix For: 2.21.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently Beam SDKs set environment in a known set of transforms and do not
> not set it in others. Runners expect certain transforms to not to resolve to
> an environment.
> It might be cleaner to set environment in all transforms by default (at the
> SDKs) and allow runners to override this for transforms that are naively
> implemented in the corresponding runners.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
