[
https://issues.apache.org/jira/browse/BEAM-9821?focusedWorklogId=433317&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-433317
]
ASF GitHub Bot logged work on BEAM-9821:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/20 19:40
Start Date: 14/May/20 19:40
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#11528:
URL: https://github.com/apache/beam/pull/11528#discussion_r425385260
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##########
@@ -991,6 +1001,24 @@ public WriteGrouped(Write spec) {
this.spec = spec;
}
+ @Override
+ public void populateDisplayData(DisplayData.Builder builder) {
+ super.populateDisplayData(builder);
+ spec.getSpannerConfig().populateDisplayData(builder);
+ builder.add(
+ DisplayData.item("batchSizeBytes", spec.getBatchSizeBytes())
+ .withLabel("Max batch size in sytes"));
+ builder.add(
+ DisplayData.item("maxNumMutations", spec.getMaxNumMutations())
+ .withLabel("Max number of mutated cells in each batch"));
+ builder.add(
+ DisplayData.item("maxNumRows", spec.getMaxNumRows())
+ .withLabel("Max number of rows in each batch"));
+ builder.add(
+ DisplayData.item("groupingFactor", spec.getGroupingFactor())
+ .withLabel("Number of batches to sort over"));
+ }
+
Review comment:
I added some commits to tweak these descriptions a bit. @nielm can you
confirm that they're still correct?
Also I wonder if you can re-use the implementation in `Write` by calling
`spec.populateDisplayData(builder)` here instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 433317)
Time Spent: 40m (was: 0.5h)
> SpannerIO does not include all batching parameters in DisplayData.
> ------------------------------------------------------------------
>
> Key: BEAM-9821
> URL: https://issues.apache.org/jira/browse/BEAM-9821
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Affects Versions: 2.20.0, 2.21.0
> Reporter: Niel Markwick
> Assignee: Niel Markwick
> Priority: Minor
> Labels: google-cloud-spanner
> Fix For: 2.22.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> SpannerIO Write and WriteGrouped do not populate all of the batching/grouping
> parameters in their DisplayData – they only show "batchSizeBytes"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
