[
https://issues.apache.org/jira/browse/BEAM-9383?focusedWorklogId=434607&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-434607
]
ASF GitHub Bot logged work on BEAM-9383:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/May/20 20:55
Start Date: 18/May/20 20:55
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426876833
##########
File path:
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java
##########
@@ -195,7 +187,7 @@ public void testFileWithExtensionPackageNamingAndSize()
throws Exception {
PackageAttributes attr = makePackageAttributes(tmpFile, null);
DataflowPackage target = attr.getDestination();
- assertThat(target.getName(), RegexMatcher.matches("file-" + HASH_PATTERN +
".txt"));
+ assertThat(target.getName(), RegexMatcher.matches(UUID_PATTERN + ".txt"));
Review comment:
You could just match `".*.txt"` here, rather than hard-coding the uuid
format. (Same blow.)
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -784,7 +877,25 @@ public DataflowPipelineJob run(Pipeline pipeline) {
"Executing pipeline on the Dataflow Service, which will have billing
implications "
+ "related to Google Compute Engine usage and other Google Cloud
Services.");
- List<DataflowPackage> packages = options.getStager().stageDefaultFiles();
+ // Capture the sdkComponents for look up during step translations
+ SdkComponents sdkComponents = SdkComponents.create();
+
+ DataflowPipelineOptions dataflowOptions =
options.as(DataflowPipelineOptions.class);
+ String workerHarnessContainerImageURL =
DataflowRunner.getContainerImageForJob(dataflowOptions);
+ RunnerApi.Environment defaultEnvironmentForDataflow =
+ Environments.createDockerEnvironment(workerHarnessContainerImageURL);
+
+ sdkComponents.registerEnvironment(
+ defaultEnvironmentForDataflow
+ .toBuilder()
+ .addAllDependencies(getDefaultArtifacts())
+ .build());
+
+ RunnerApi.Pipeline pipelineProto = PipelineTranslation.toProto(pipeline,
sdkComponents, true);
+
+ LOG.debug("Portable pipeline proto:\n{}",
TextFormat.printToString(pipelineProto));
Review comment:
OK, we don't have to change this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 434607)
Time Spent: 9h 10m (was: 9h)
> Staging Dataflow artifacts from environment
> -------------------------------------------
>
> Key: BEAM-9383
> URL: https://issues.apache.org/jira/browse/BEAM-9383
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P0
> Fix For: 2.22.0
>
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
> Staging Dataflow artifacts from environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
