[ https://issues.apache.org/jira/browse/BEAM-9699?focusedWorklogId=435084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-435084 ]
ASF GitHub Bot logged work on BEAM-9699: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/May/20 17:46 Start Date: 19/May/20 17:46 Worklog Time Spent: 10m Work Description: robertwb commented on a change in pull request #11575: URL: https://github.com/apache/beam/pull/11575#discussion_r427485815 ########## File path: sdks/python/apache_beam/transforms/sql.py ########## @@ -31,8 +31,15 @@ __all__ = ['SqlTransform'] +_SQL_PLANNERS = { + 'zetasql': 'org.apache.beam.sdk.extensions.sql.zetasql.ZetaSQLQueryPlanner', Review comment: I wonder if it would make more sense for this mapping to live on the Java side, and to have this parameter by called "dialect" or similar. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 435084) Time Spent: 1.5h (was: 1h 20m) > Add ability to use ZetaSQL in Python SqlTransform > ------------------------------------------------- > > Key: BEAM-9699 > URL: https://issues.apache.org/jira/browse/BEAM-9699 > Project: Beam > Issue Type: Improvement > Components: dsl-sql, sdk-py-core > Reporter: Brian Hulette > Assignee: Brian Hulette > Priority: P2 > Time Spent: 1.5h > Remaining Estimate: 0h > > This may just work when the [plannerName pipeline > option|https://github.com/apache/beam/blob/1e52e4298085eda8e88e1215c7a73d52658b31f1/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlPipelineOptions.java#L29] > is exposed to Python -- This message was sent by Atlassian Jira (v8.3.4#803005)