[
https://issues.apache.org/jira/browse/BEAM-10007?focusedWorklogId=435156&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-435156
]
ASF GitHub Bot logged work on BEAM-10007:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/May/20 20:02
Start Date: 19/May/20 20:02
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #11744:
URL: https://github.com/apache/beam/pull/11744#discussion_r427565668
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -164,10 +165,19 @@ def add_runner_options(parser):
all_options = self.options.get_all_options(
add_extra_args_fn=add_runner_options,
retain_unknown_options=self._retain_unknown_options)
+
# TODO: Define URNs for options.
# convert int values: https://issues.apache.org/jira/browse/BEAM-5509
+ def convert_pipeline_option_value(v):
+ if type(v) == int:
Review comment:
why there is a special case for int? Can we do str(v) for everything
except for valueproviders?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 435156)
Time Spent: 20m (was: 10m)
> PortableRunner doesn't handle ValueProvider instances when converting
> pipeline options
> --------------------------------------------------------------------------------------
>
> Key: BEAM-10007
> URL: https://issues.apache.org/jira/browse/BEAM-10007
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Brian Hulette
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We attempt to convert ValueProvider instances directly to JSON with
> json_format, leading to errors like the one described in BEAM-9975.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
