[
https://issues.apache.org/jira/browse/BEAM-10003?focusedWorklogId=436487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-436487
]
ASF GitHub Bot logged work on BEAM-10003:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/20 11:40
Start Date: 22/May/20 11:40
Worklog Time Spent: 10m
Work Description: kgabryje commented on pull request #11796:
URL: https://github.com/apache/beam/pull/11796#issuecomment-632648552
Hi @rezarokni , this PR solves the issue submitted by you. Can you take a
look?
Also @pabloem , I'd appreciate if you took a look as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 436487)
Time Spent: 20m (was: 10m)
> Need two PR to submit snippets to website
> -----------------------------------------
>
> Key: BEAM-10003
> URL: https://issues.apache.org/jira/browse/BEAM-10003
> Project: Beam
> Issue Type: New Feature
> Components: website
> Reporter: Reza ardeshir rokni
> Assignee: Aizhamal Nurmamat kyzy
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Looks like build_github_samples.sh uses code already on the repo to build
> local serving;
> do
> fileName=$(echo "$url" | sed -e 's/\//_/g')
> curl -o "$DIST_DIR"/"$fileName"
> "[https://raw.githubusercontent.com|https://raw.githubusercontent.com/]$url";
> done
> So when tying to test locally, the code needs to have already be in Beam.
> Ideally the script should make use of local code when building so :
> 1- Easier to build & test changes.
> 2- No need to raise two PR for what is a single change
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
