[ https://issues.apache.org/jira/browse/BEAM-7774?focusedWorklogId=437691&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437691 ]
ASF GitHub Bot logged work on BEAM-7774: ---------------------------------------- Author: ASF GitHub Bot Created on: 27/May/20 08:13 Start Date: 27/May/20 08:13 Worklog Time Spent: 10m Work Description: piotr-szuberski commented on a change in pull request #11661: URL: https://github.com/apache/beam/pull/11661#discussion_r430935474 ########## File path: sdks/python/apache_beam/examples/wordcount_it_test.py ########## @@ -104,18 +107,33 @@ def _run_wordcount_it(self, run_wordcount, **opts): run_time = end_time - start_time if publish_to_bq: - bq_publisher = BigQueryMetricsPublisher( - project_name=test_pipeline.get_option('project'), - table=test_pipeline.get_option('metrics_table'), - dataset=test_pipeline.get_option('metrics_dataset'), - ) - result = Metric( - submit_timestamp=time.time(), - metric_id=uuid.uuid4().hex, - value=run_time, - label='Python performance test', - ) - bq_publisher.publish([result.as_dict()]) + self._publish_metrics(test_pipeline, run_time) + + def _publish_metrics(self, pipeline, metric_value): Review comment: I can add something like "publish_single_value_(bq/influx/console)" for each publisher ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 437691) Time Spent: 3h (was: 2h 50m) > Stop usign Perfkit Benchmarker tool in Python performance tests > --------------------------------------------------------------- > > Key: BEAM-7774 > URL: https://issues.apache.org/jira/browse/BEAM-7774 > Project: Beam > Issue Type: Sub-task > Components: testing > Reporter: Lukasz Gajowy > Assignee: Piotr Szuberski > Priority: P2 > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)