[
https://issues.apache.org/jira/browse/BEAM-10066?focusedWorklogId=437715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437715
]
ASF GitHub Bot logged work on BEAM-10066:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/May/20 09:40
Start Date: 27/May/20 09:40
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #11799:
URL: https://github.com/apache/beam/pull/11799#issuecomment-634548871
@naipath Can you please run `./gradlew :sdks:java:io:redis:check
spotlessApply` and update the PR, can you also please change the commit title
to include the ticket: "[BEAM-10066] Added support for ValueProvider in
RedisConnectionConfiguration" Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 437715)
Remaining Estimate: 0.5h (was: 40m)
Time Spent: 0.5h (was: 20m)
> Support ValueProvider for RedisIO
> ---------------------------------
>
> Key: BEAM-10066
> URL: https://issues.apache.org/jira/browse/BEAM-10066
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Affects Versions: 2.20.0
> Reporter: Teije van Sloten
> Assignee: Teije van Sloten
> Priority: P3
> Original Estimate: 1h
> Time Spent: 0.5h
> Remaining Estimate: 0.5h
>
> RedisIO doesn't have support for `ValueProvider` when setting up the
> connection with Redis, therefore I cannot provide the connection at runtime
> of the application only at compile time.
> This will involve wrapping the RedisConnectionConfiguration with
> ValueProvider and ensuring that the building the configuration still supports
> values without ValueProvider.
> E.g.:
>
> {code:java}
> public abstract class RedisConnectionConfiguration implements Serializable {
> abstract ValueProvider<String> host();
> abstract ValueProvider<Integer> port();
> @Nullable
> abstract ValueProvider<String> auth();
> abstract ValueProvider<Integer> timeout();
> abstract ValueProvider<Boolean> ssl();
> abstract Builder builder();
> }
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
