[
https://issues.apache.org/jira/browse/BEAM-9679?focusedWorklogId=441346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441346
]
ASF GitHub Bot logged work on BEAM-9679:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/20 15:31
Start Date: 04/Jun/20 15:31
Worklog Time Spent: 10m
Work Description: damondouglas commented on a change in pull request
#11883:
URL: https://github.com/apache/beam/pull/11883#discussion_r435349866
##########
File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go
##########
@@ -47,9 +47,9 @@ func (c *averageFn) MergeAccumulators(accumA, accumB
averageAccum) averageAccum
}
}
-func (c *averageFn) ExtractOutput(accum averageAccum) float64 {
+func (c *averageFn) ExtractOutput(accum averageAccum) int {
Review comment:
Thank you, Henry. Are we ok with this then?
```
func (c *averageFn) ExtractOutput(accum averageAccum) float64 {
if accum.Count == 0 {
return 0
}
return float64(accum.Sum / accum.Count)
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 441346)
Time Spent: 8h 20m (was: 8h 10m)
> Core Transforms | Go SDK Code Katas
> -----------------------------------
>
> Key: BEAM-9679
> URL: https://issues.apache.org/jira/browse/BEAM-9679
> Project: Beam
> Issue Type: Sub-task
> Components: katas, sdk-go
> Reporter: Damon Douglas
> Assignee: Damon Douglas
> Priority: P2
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> A kata devoted to core beam transforms patterns after
> [https://github.com/apache/beam/tree/master/learning/katas/java/Core%20Transforms]
> where the take away is an individual's ability to master the following using
> an Apache Beam pipeline using the Golang SDK.
>
> ||Transform||Pull Request||Status||
> |Map|[11564|https://github.com/apache/beam/pull/11564]|Closed|
> |GroupByKey|[11734|https://github.com/apache/beam/pull/11734]|Closed|
> |CoGroupByKey|[11803|https://github.com/apache/beam/pull/11803]|Closed|
> |Combine Simple
> Function|[11866|https://github.com/apache/beam/pull/11866]|Closed|
> |CombineFn|[11883|https://github.com/apache/beam/pull/11883]|Open|
> |Flatten|[11806|https://github.com/apache/beam/pull/11806]|Closed|
> |Partition| | |
> |Side Input| | |
> |Side Output| | |
> |Branching| | |
> |Composite Transform| | |
> |DoFn Additional Parameters| | |
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
